[2.0.x] Automatically reset stepper timeout#10179
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom Mar 22, 2018
Merged
[2.0.x] Automatically reset stepper timeout#10179thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
thinkyhead
force-pushed
the
bf2_auto_reset_stepper_timeout
branch
from
4b65dc1 to
3f5c03b
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
from
8960719 to
9fd1016
Compare
Any code that adds moves to the planner can skip resetting the stepper timeout. We can let `idle` / `manage_inactivity` reset the timer whenever it detects any moves in the planner.
thinkyhead
force-pushed
the
bf2_auto_reset_stepper_timeout
branch
from
3f5c03b to
0f65872
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responding to #9980…
Currently if you add a single move to the planner that takes longer than the
max_inactive_time(as set byM85) the steppers will power off immediately after the move completes.This PR adds code to
manage_inactivityto reset the timer whenever the planner has a block.As a result of this change, any code that adds moves to the planner can skip resetting the stepper timeout. We can let
idle/manage_inactivityreset the timer whenever it detects any moves in the planner.Continue to call
reset_stepper_timeoutfrom any code that wants to prevent the steppers from sleeping, such as, for example, when waiting for a user response between manual probes.Also:
refresh_cmd_timeouttoreset_stepper_timeoutandprevious_cmd_mstoprevious_move_msto make it clear these pertain to the stepper timeout.blocks_queuedtohas_blocks_queuedto clarify that it's a flag.Counterpart to #10178