[2.0.x] More complete Trinamic driver options#10102
Merged
thinkyhead merged 4 commits intoMarlinFirmware:bugfix-2.0.xfrom Mar 21, 2018
Merged
[2.0.x] More complete Trinamic driver options#10102thinkyhead merged 4 commits intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 4 commits intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
thinkyhead
force-pushed
the
bf2_eeprom_M913
branch
7 times, most recently
from
6ba39d3 to
e0a9160
Compare
thinkyhead
force-pushed
the
bf2_eeprom_M913
branch
4 times, most recently
from
082628d to
4faeabf
Compare
thinkyhead
changed the title
teemuatlut
suggested changes
Mar 15, 2018
Member
teemuatlut
left a comment
teemuatlut
left a comment
There was a problem hiding this comment.
I think the M503 output needs a few changes. There are other places too where we need to account for dual steppers and report both.
Member
There was a problem hiding this comment.
What's the purpose for declaring extruder if it is not used within the scope?
Member
Author
There was a problem hiding this comment.
E_AXIS_N uses it when DISTINCT_E_FACTORS is enabled.
Member
There was a problem hiding this comment.
Both X and X2 can be TMC drivers and so should output both.
It might also look cleaner if the output was
M906 X800 Y800
M906 I2 X800 Y800
vs
M906 X800
M906 I2 X800
M906 Y800
M906 I2 Y800
Member
Author
There was a problem hiding this comment.
Oops. I thought I had changed them to all be independent, without #elif. I'll fix that.
thinkyhead
force-pushed
the
bf2_eeprom_M913
branch
from
4faeabf to
437f397
Compare
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
from
2308508 to
1e946d6
Compare
thinkyhead
force-pushed
the
bf2_eeprom_M913
branch
6 times, most recently
from
317cbc3 to
7743c7c
Compare
thinkyhead
force-pushed
the
bf2_eeprom_M913
branch
from
7743c7c to
a46bac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #10087
M913Hybrid Threshold.TMC_AxisEnumto match EEPROM storage.Tparameter toM906/M913to specific which extruder.I(index) parameter toM906/M913/M914to specify which dual axis stepper.Concise Diff
Counterpart to #10101