Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Define Malyan M300 E0_AUTO_FAN_PIN directly #1074

Merged

Conversation

thisiskeithb
Copy link
Member

Description

Drop the alias for now in preparation for MarlinFirmware/Marlin#27214

Benefits

Upstream CI will pass 😄

Related Issues

@thinkyhead
Copy link
Member

The board provides a pin for this, and we want boards to be able to provide these pins and have them automatically assigned without users needing to know the pin number. So the correct solution (for now) is to leave the pin undefined and let the pins file define it for us.

@thinkyhead thinkyhead merged commit 28b8be2 into MarlinFirmware:import-2.1.x Jun 27, 2024
1 check passed
@thisiskeithb thisiskeithb deleted the pr/update_m300_e0_auto_fan branch June 27, 2024 18:50
@thisiskeithb
Copy link
Member Author

thisiskeithb commented Jun 27, 2024

The board provides a pin for this, and we want boards to be able to provide these pins and have them automatically assigned without users needing to know the pin number. So the correct solution (for now) is to leave the pin undefined and let the pins file define it for us.

The pins file provides AUTO_FAN_PIN which is not E0_AUTO_FAN_PIN and now this config is unsafe because it no longer enables the hotend cooling fan. I fixed this in MarlinFirmware/Marlin#27214, which is why I was defining the pin directly here to ensure that the hotend auto fan still works for this config while things are hashed out in the linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants