Update jquery-ui to 1.13.3 and move jquery-ui and ui-contextmenu to package.json #7149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
First, the version of jquery-ui we were using was out of date and contained some security issues (e.g. https://github.com/MarkUsProject/Markus/security/code-scanning/25). Second, it was being included as a vendored library, making it harder to manage updates.
I've now moved jquery-ui into
package.json
, as well as another dependent library,ui-contextmenu
. I needed to modify the webpack configuration to ensure these libraries could be compiled with webpack. I then removed old Javascript files undervendor/assets/javascripts
. Note that jCrop was already in package.json, so that vendored file could just be removed. The last remaining vendored jquery-related JS file,jquery.easyModal.js
, doesn't have a corresponding npm package, so couldn't be easily moved topackage.json
.Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
We are working to migrate away from the jQuery easyModal library to
react-modal
.