Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow offline testing with a centralised mock function #68

Closed
MarkEdmondson1234 opened this issue Jun 4, 2017 · 1 comment
Closed

Allow offline testing with a centralised mock function #68

MarkEdmondson1234 opened this issue Jun 4, 2017 · 1 comment

Comments

@MarkEdmondson1234
Copy link
Owner

MarkEdmondson1234 commented Jun 4, 2017 •
edited
Loading

https://github.com/n-s-f/mockery
https://github.com/gaborcsardi/httrmock
https://github.com/ropensci/vcr

https://discuss.ropensci.org/t/best-practices-for-testing-api-packages/460/8

Don't test that API, test the functions. Some way to test what the JSON, URL etc. is sent by a googleAuthR API call, recording one successful version then keeping that in a file for comparison in unit tests.
MarkEdmondson1234 added a commit that referenced this issue Jun 4, 2017
@MarkEdmondson1234
first try at mock API calls (#68)
6611d32
MarkEdmondson1234 added a commit that referenced this issue Jun 4, 2017
@MarkEdmondson1234
add mock tests to batching (#68)
984e2ac
MarkEdmondson1234 added a commit that referenced this issue Jun 4, 2017
@MarkEdmondson1234
more unique hashes for batched HTTP calls (#68)
4050579
@MarkEdmondson1234 MarkEdmondson1234 mentioned this issue Jun 4, 2017
Closed
MarkEdmondson1234 added a commit that referenced this issue Jun 5, 2017
@MarkEdmondson1234
refactor so caching one application of mock (#68 and #69)
c4eda9c
@MarkEdmondson1234
Copy link
Owner Author

Carried on in #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarkEdmondson1234