Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of isFALSE in R < 3.5 #158

Closed
matthijsvanderloos opened this issue Sep 6, 2019 · 2 comments
Closed

Use of isFALSE in R < 3.5 #158

matthijsvanderloos opened this issue Sep 6, 2019 · 2 comments

Comments

@matthijsvanderloos
Copy link

What goes wrong

While using the package in R <3.5 the following error is raised:

Error in isFALSE(.auth$auth_active) : could not find function "isFALSE"

Apparently a function in the package uses base::isFALSE() but this has only been introduced in R 3.5. The requirements for googleAuthR are R >= 3.3.0, however.

@MarkEdmondson1234
Copy link
Owner

Thanks, I will raise the requirements

@MarkEdmondson1234
Copy link
Owner

Hmm actually thats a pretty big step for just one function, instead I'll put it in as a utility like gargle does

isFALSE <- function(x) identical(x, FALSE)

So it should still be ok on R 3.3.0 after this commit.

MarkEdmondson1234 added a commit that referenced this issue Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants