Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check parameters are encoded by default going in #101

Closed
MarkEdmondson1234 opened this issue Nov 3, 2017 · 4 comments
Closed

Check parameters are encoded by default going in #101

MarkEdmondson1234 opened this issue Nov 3, 2017 · 4 comments

Comments

@MarkEdmondson1234
Copy link
Owner

Looks like it doesn't as per #100

@MarkEdmondson1234
Copy link
Owner Author

This unfortunately broke bigQueryR as it can't deal with NULL parameters.

@carlganz
Copy link

This broke my code as well. This works:

paste(names(pars_args), 
             vapply(pars_args, URLencode, reserved = TRUE, character(1)), 
             sep='=', collapse='&')

vapply checks that each value returned is consistent with FUN.VALUE i.e. if FUN.VALUE is length n then it checks that each value returned is length n.

@MarkEdmondson1234
Copy link
Owner Author

Thanks @carlganz ! I'll put that in now so at least GitHub works

MarkEdmondson1234 added a commit that referenced this issue Nov 13, 2017
MarkEdmondson1234 added a commit that referenced this issue Nov 13, 2017
@MarkEdmondson1234
Copy link
Owner Author

I think this is done, but let me know if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants