Skip to content

Commit

Permalink
0.3.1 prep
Browse files Browse the repository at this point in the history
  • Loading branch information
MarkEdmondson1234 committed Jun 24, 2016
1 parent 8fa166e commit 974860c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 20 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Authors@R: c(person("Mark", "Edmondson",email = "[email protected]",
role = c("aut", "cre")),
person("Jennifer", "Bryan",email="[email protected]", role = "ctb"),
person("Johann", "deBoer", email="[email protected]", role = "ctb"))
URL: https://github.com/MarkEdmondson1234/googleAuthR
URL: http://code.markedmondson.me/googleAuthR/
BugReports: https://github.com/MarkEdmondson1234/googleAuthR/issues
Depends:
R (>= 3.2.0)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ options("googleAuthR.scopes.selected" = c("https://www.googleapis.com/auth/webma
2. Click 'Create a new Client ID', and choose "Web Application".
3. Note your Client ID and secret.
4. Add the URL of where your Shiny app will run, with no port number. e.g. https://mark.shinyapps.io/searchConsoleRDemo/
5. And/Or also put in localhost or 127.0.0.1 with a port number for local testing. Remember the port number you use as you will need it later to launch the app e.g. http://127.0.0.1:1221
5. And/Or also put in localhost or 127.0.0.1 with a port number for local testing. Remember the port number you use as you will need it later to launch the app e.g. `http://127.0.0.1:1221`
6. In your Shiny script modify these options:
+ `options("googleAuthR.webapp.client_id" = "YOUR_CLIENT_ID")`
+ `options("googleAuthR.webapp.client_secret" = "YOUR_CLIENT_SECRET")`
Expand Down
26 changes: 9 additions & 17 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
## R CMD check results
There were no ERRORs or WARNINGs.

There were 2 NOTEs:
There was 1 NOTE:

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Mark Edmondson <[email protected]>'
Expand All @@ -22,22 +22,14 @@ There were 2 NOTEs:
APIs (5:66)
OAuth (4:40, 5:52)

These are spelt as intended.
These are spelt as intended.

## Downstream dependencies
I have also run R CMD check on downstream dependencies of googleAuthR

* checking dependencies in R code ... NOTE
Namespace in Imports field not imported from: 'R6'
* bigQueryR
* googleAnalyticsR
* searchConsoleR

R6 is a build-time dependency.

* Found the following (possibly) invalid URLs:
URL: https://code.google.com/apis/console (moved to https://console.developers.google.com/dcredirect)
From: inst/doc/googleAuthR.html
Status: 404
Message: Not Found
URL: https://console.developers.google.com/apis/credentials/serviceaccountkey
From: inst/doc/googleAuthR.html
Status: 404
Message: Not Found

These URLs are correct but are behind a login that can't be crawled by the CRAN checker.
All packages passed.

2 changes: 1 addition & 1 deletion vignettes/googleAuthR.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ options("googleAuthR.scopes.selected" = c("https://www.googleapis.com/auth/webma
2. Click 'Create a new Client ID', and choose "Web Application".
3. Note your Client ID and secret.
4. Add the URL of where your Shiny app will run, with no port number. e.g. https://mark.shinyapps.io/searchConsoleRDemo/
5. And/Or also put in localhost or 127.0.0.1 with a port number for local testing. Remember the port number you use as you will need it later to launch the app e.g. http://127.0.0.1:1221
5. And/Or also put in localhost or 127.0.0.1 with a port number for local testing. Remember the port number you use as you will need it later to launch the app e.g. `http://127.0.0.1:1221`
6. In your Shiny script modify these options:
+ `options("googleAuthR.webapp.client_id" = "YOUR_CLIENT_ID")`
+ `options("googleAuthR.webapp.client_secret" = "YOUR_CLIENT_SECRET")`
Expand Down

0 comments on commit 974860c

Please sign in to comment.