-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify CACHE_DIR when deploying with GH actions #2542
Conversation
Yay! Quick question... Is it possible for the user to set their cache directory for gh-pages to some other location? If they do this, does it become incompatible with MarkBind? |
@kaixin-hc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@EltonGohJH Thanks for the quick fix. |
Fixes issue after release but not before: |
hmm... I'm still facing this when deploying. Perhaps it fixed the problem for GitHub Actions only?
|
BTW, earlier I used to find (and delete) the |
@damithc
|
Thanks @EltonGohJH |
@damithc |
What is the purpose of this pull request?
Overview of changes:
Fixes #2538
Anything you'd like to highlight/discuss:
I have verified with my fork that setting cache directory will actually fix the bug.
So, the bug is actually due to not being able to locate .cache folder when running
markbind deploy --ci
with github actions.Link to my fork where I set the env variable and it works
EltonGohJH/2024@c6d2191
Testing instructions:
I think we will need to release it to test it unfortunately.
Proposed commit message: (wrap lines at 72 characters)
Specify cache directory so GH Actions can locate gh-pages cache folder
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):