Lutron pico remote #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As relates to arallsopp/hass-hue-icons#202
Integrated lutron remote icons for @sdholden28
|
thanks @arallsopp been a while since I revisited so have to check what to do ;-) Ill approve ofc. |
|
btw, do we need a new release for this? |
|
|
Andy, could you please check the custom-icons.js file in the last update (which I released yesterday). I threw them in my custom icons folder and the custom component sees them correctly. The integration doesnt however, something must be off? loading the file in my local test config does work and I can see the Lutron icons fine.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the svgs and manually edited the custom-icons.js to include them. I've not changed the readme or the screen caps as I think you generate those using utilities. Can't remember to be honest, which will be slightly embarrasing if it turns out I wrote them :)
Linking @sdholden28 to this conversation, so that they can track the changes and see when it gets promoted.