fix: testing_buildBlockV1, deterministic access list, console test#71
fix: testing_buildBlockV1, deterministic access list, console test#71MysticRyuujin wants to merge 12 commits intoMariusVanDerWijden:testing-buildblockfrom
Conversation
MysticRyuujin
commented
Feb 4, 2026
MysticRyuujin
commented
- miner: OnlyProvidedTxs/UseExplicitExtra for testing_buildBlockV1; sync payload when only provided txs
- eth/catalyst: BuildPayload with OnlyProvidedTxs and UseExplicitExtra for testing API
- eth/tracers/logger: sort access list addresses and storage keys for deterministic eth_createAccessList
- internal/ethapi/override: sort addresses for deterministic state override error messages
- cmd/geth: expect testing:1.0 in console IPC APIs
- miner: OnlyProvidedTxs/UseExplicitExtra for testing_buildBlockV1; sync payload when only provided txs - eth/catalyst: BuildPayload with OnlyProvidedTxs and UseExplicitExtra for testing API - eth/tracers/logger: sort access list addresses and storage keys for deterministic eth_createAccessList - internal/ethapi/override: sort addresses for deterministic state override error messages - cmd/geth: expect testing:1.0 in console IPC APIs
|
I don't like that idea of accepting both transactions via the endpoint and the txpool. We should only do one. Same with the extradata. We should only ever use the extradata provided by the endpoint. Let me try to implement that so we can use []byte{} as extradata as well |
|
I don't entirely understand the feedback, this is how the spec is written, if TXs are passed those TXs (and only those TXs) must be included in the block, if an empty array is passed then no TXs can be included in the block, it must be an empty block. For the API endpoint there is no "accepting both transactions via the endpoint and the txpool" or did I mess something up? As for extraData the spec says if extraData is passed it must be used as is, but it does not say what to do if extraData is NOT passed, to which I assume it would either be "0x" or the client's default. |
|
The AI made some mistakes then. |
MariusVanDerWijden
force-pushed
the
testing-buildblock
branch
from
459ea33 to
348f1d7
Compare
3 participants
