MDEV-35614 json unquote utf8mb4 #3694
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return an error, and handle let the caller handler the SQL error.
Add the attribute warn_unused_result on the functions to ensure they are handled.
Push a warning if the unescaping failed to resolve into the target character set. This uses the ER_JSON_BAD_CHAR, which is normally around functions, but we can't add new error codes so use this as is. Use same args for the error as JSON functions would for this error code.
emojis are a 4 byte utf sequence. Fix the conversion in JSON_UNQUOTE to utf8mb4_bin by default.
grooverdan
force-pushed
the
10.5-MDEV-35614-json_unquote_utf8mb4
branch
2 times, most recently
from
18ee060 to
c1a7fde
Compare
JSON functions append in multiple ways, however there isn't always error handling, and many time it doesn't make it to the end user. Made the appending string functions withing item_jsonfunc warn if their true/false result (did an error occur) isn't handled. Add error handling to many json functions. realloc_with_extra_if_needed was also previously lacking OOM handing.
grooverdan
force-pushed
the
10.5-MDEV-35614-json_unquote_utf8mb4
branch
from
c1a7fde to
7d024cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No smiley emojis in JSON_UNQUOTE.
Release Notes
Smilieys are back.
How can this PR be tested?
basic test case there. Need to do more (and probably split out non-json commits)
Basing the PR against the correct MariaDB version
mainbranch.PR quality check