Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVELOPMENT_BRANCH=main #615

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

grooverdan
Copy link
Member

This affects how and which install/upgrade tests are done.

Copy link
Collaborator

@RazvanLiviuVarzaru RazvanLiviuVarzaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://mariadb.com/kb/en/mariadb-upgrade/
You should run mariadb-upgrade after upgrading from one major MySQL/MariaDB release to another

Running mariadb-upgrade if [[ $test_type == "major" ]] will suffice.

Right now, we are doing things a bit differently between RPM and DEB as:
For DEB is wrong because it won't evaluate as true in most cases.

if [[ $major_version == "$development_branch" ]]; then
  sudo mariadb-upgrade
fi

And for RPM we are lucky we have the OR major upgrade condition.

if [[ $major_version == "$development_branch" ]] || [[ $test_type == "major" ]]; then
  sudo mariadb-upgrade
fi

Another thought is that mariadb-upgrade can catch early incompatibilities for minor upgrades too. So why not remove any condition and run it everytime, no matter the test_type?
It's also safe to run mariadb-upgrade for minor upgrades, as if there are no incompatibilities nothing is changed.

@cvicentiu any thoughts on this?

This affects how and which install/upgrade tests are done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants