-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async UDF, variant arrays, some optimisations #6
Open
ronniec95
wants to merge
39
commits into
MarcusRainbow:master
Choose a base branch
from
ronniec95:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've also added a feature gated try_from API for when it becomes stable in Rust. It could be useful for those using nightly. I would suggest removing the old from_* methods but it's up to you if you wish to break existing code once that's done |
and latest rust ergonomics
# Conflicts: # Cargo.lock
Removed extraneous commented code Added Error derive
Some bugfixes when unexpected data from Excel
…empty. It would crash with a div by 0 error
…t being passed in correctly
…e returned to excel which significantly enhances user experience. You can now label fields with text and then have numbers. Cost: Slightly slower as not all types are stored sequentially if string/f64 combination.
Upped array size to 1,048,575 Added macros to return tables make_row/col which makes it easier to manipulate complex structures
ronniec95
changed the title
Added bool conversion from Variant
Async UDF, variant arrays, some optimisations
Jan 8, 2021
Added support for reference ranges such as those from OFFSET/INDEX Helper macros for creating variant tables make_rol_table,make_col_table and also check_arr to check all values are non zero/nan which is often useful for math code
…s returning a nil value rather than the actual value
…e and it was not converting
…. Also handle some other Excel errors appropriately Added variant,usize => variant conversion to return heterogeneous typed array back to excel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the conversion function to bool so users can call a function with the syntax =FOO(TRUE) rather than the string "TRUE"