-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependenices to latest and use type imports #27
chore(deps): update dependenices to latest and use type imports #27
Conversation
Cool! I will double check that the package upgrades work, as many of these upgrades are major versions and breaking. I'm pretty limited on time atm but happy to merge this in a few days when I've verified that nothing breaks with it. |
oh yeah this is like 10 major versions, no rush. It builds so I assume it works (as we all should) |
Might be good to setup Dependabot in the future to get automatic PRs with |
A better one is renovate. I suggest renovate. This also needs an update as dotenv 14 is now latest. |
Converted to draft as I need to fix merge conflicts and update the package again |
That's fine, I can fix these merge conflicts. I created them after all 😄 |
still needs another breaking update 😉 |
@MarcusOtter Ready for review + test |
Have at it, no concerns here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this out locally and everything seems to work! I did have to upgrade my ESLint VSC extension to pre-release mode for it to recognize the new type syntax, but other than that no issues. Oh, and I changed the README to state the new minimum NodeJS version
it's 2022 and year old get-rid-of-type-only-imports
liberty also struck by updating the package to latest version(s)