Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependenices to latest and use type imports #27

Merged
merged 9 commits into from
Feb 1, 2022
Merged

chore(deps): update dependenices to latest and use type imports #27

merged 9 commits into from
Feb 1, 2022

Conversation

c43721
Copy link
Contributor

@c43721 c43721 commented Jan 12, 2022

it's 2022 and year old get-rid-of-type-only-imports

liberty also struck by updating the package to latest version(s)

@MarcusOtter
Copy link
Owner

Cool! I will double check that the package upgrades work, as many of these upgrades are major versions and breaking. I'm pretty limited on time atm but happy to merge this in a few days when I've verified that nothing breaks with it.

@c43721
Copy link
Contributor Author

c43721 commented Jan 12, 2022

oh yeah this is like 10 major versions, no rush. It builds so I assume it works (as we all should)

@n1ckoates
Copy link
Contributor

Might be good to setup Dependabot in the future to get automatic PRs with package.json upgrades.

@c43721
Copy link
Contributor Author

c43721 commented Jan 26, 2022

A better one is renovate. I suggest renovate. This also needs an update as dotenv 14 is now latest.

@c43721 c43721 marked this pull request as draft January 31, 2022 15:14
@c43721
Copy link
Contributor Author

c43721 commented Jan 31, 2022

Converted to draft as I need to fix merge conflicts and update the package again

@c43721 c43721 mentioned this pull request Jan 31, 2022
Merged
3 tasks
@MarcusOtter
Copy link
Owner

That's fine, I can fix these merge conflicts. I created them after all 😄

@c43721
Copy link
Contributor Author

c43721 commented Jan 31, 2022

still needs another breaking update 😉

@c43721
Copy link
Contributor Author

c43721 commented Feb 1, 2022

image
New deps

@c43721 c43721 marked this pull request as ready for review February 1, 2022 01:02
@c43721
Copy link
Contributor Author

c43721 commented Feb 1, 2022

@MarcusOtter Ready for review + test

@MarcusOtter
Copy link
Owner

Nice! Are you okay with changing the license to AGPL 3.0 as outlined in #38 @c43721?

@c43721
Copy link
Contributor Author

c43721 commented Feb 1, 2022

Have at it, no concerns here.

Copy link
Owner

@MarcusOtter MarcusOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out locally and everything seems to work! I did have to upgrade my ESLint VSC extension to pre-release mode for it to recognize the new type syntax, but other than that no issues. Oh, and I changed the README to state the new minimum NodeJS version

@MarcusOtter MarcusOtter merged commit 2ce78dd into MarcusOtter:main Feb 1, 2022
@c43721 c43721 deleted the chore/update-deps-to-latest branch February 1, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants