-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 464 #465
base: master
Are you sure you want to change the base?
Conversation
I'll hopefully get to testing this tomorrow. Looks like a promising feature. |
Ran the first leg of the test (ini file unchanged), and got problem records for every object. Retrieved XML but no jpeg. |
What's in your mik.log? |
And manipulator.log |
|
OK, thanks, |
Sorry, I gave you the wrong log output!
|
Can you add |
Set it to false, still problems.
|
As far as I know, that problem is specific to Macs, so I'm afraid I can't be of much help troubleshooting it. See https://github.com/MarcusBarnes/mik/wiki/Cookbook:-Running-MIK-on-Mac-OS-X, which is based on information at the official Guzzle documentation at http://docs.guzzlephp.org/en/stable/request-options.html#verify. @MarcusBarnes any suggestions? |
Another error -- I tried using the regular CSV Single File toolchain with this branch (by accident), got the following:
On the master branch it's fine. |
Branches are out of sync. I'll need to cut a new one from the most recent master. Won't get a chance to do that until after noon my time. |
If you got far enough to find that glitch, it sounds like the certificate stuff is no longer a problem. Is that the case? |
@mjordan No, it's still the case for OAI toolchain. (Just ran it again to confirm.) Just an additional problem with this branch. |
Github issue: #464
What does this Pull Request do?
Adds a fetcher manipulator that restricts the objects harvested via OAI to ones whose OBJ (or other designated datastream) have one of the specified MIME types.
What's new?
A new class file,
src/fetchermanipulators/OaipmhIslandoraByMimetype.php
, and some minor cleanup on testing for an HTTP 200 insrc/filegetters/OaipmhIslandoraObj.php
.How should this be tested?
There are no PHPUnit tests for this fetcher manipulator.
To test, use the attached .ini file.
First, run MIK with the fetcher manipulator configured to only harvest objects with the MIME type
image/jpeg
. This will harvest all 73 objects in the collection:Your output directory should contain .xml and .jpeg files for all 73 objects.
Then, uncomment the fetcher manipulator entry in the .ini file with the
image/png
MIME type and comment out the other entry. Then rerun MIK, making sure that you delete your output and temp directories first:Your output directory should contain no .xml and .jpeg files, since none of the objects in the harvested collection had the
image/png
MIME type.Additional Notes
Wiki entry for this new manipulator is at https://github.com/MarcusBarnes/mik/wiki/Fetcher-manipulator:-OaipmhIslandoraByMimetype. We should link to this wiki entry in the "Manipulators" section of https://github.com/MarcusBarnes/mik/wiki/Toolchain:-OAI-PMH-for-Islandora-repositories.
Interested parties
@MarcusBarnes @bondjimbond
issue-464.ini.txt