Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing something about italian trains #17

Merged
merged 10 commits into from
Jan 31, 2023
Merged

Fixing something about italian trains #17

merged 10 commits into from
Jan 31, 2023

Conversation

giuseppeM99
Copy link
Contributor

@giuseppeM99 giuseppeM99 commented Jan 26, 2023 •
edited
Loading

The goods:

  • Updated viaggiatreno.it API endpoint
  • Fixed viaggiatreno andamentoTreno API call
  • Better (says me) itinerary layout
  • Fixed stats button
  • Trains are now called by their type (now with buses)
  • Converted delay graph generation from plotly to matplotlib

The bad:
¯_(ツ)_/¯

MarcoBuster
MarcoBuster approved these changes Jan 31, 2023
View reviewed changes
Copy link
Owner

@MarcoBuster MarcoBuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR :)

LGTM!

@MarcoBuster MarcoBuster merged commit 0c049ef into MarcoBuster:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoBuster MarcoBuster MarcoBuster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giuseppeM99 @MarcoBuster