-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python implementation pickling #91
Conversation
Excuse me, but why you have renamed also PS: I added a build and test for the pure py implementation in the pipeline, so I'm going to remove the pure py tests from the C extension tests. Wait for it. |
I explained this in the PR description. Existing files that have been pickled on python 3.11 mention Moving the python implementation and setting up |
7db1d83
to
729700a
Compare
Ok, but what if I pickle At this point, is it not much simpler to remove |
If you pickle |
This PR is split into two commits for easier review since git doesn't correctly show the rename operation on
core.py
😞 .The first moved the pure python implementation to
_frozendictpy
so thatcore.py
can become a compatibility wrapper, but makes no other changes. This allows existing pickles that mentionfrozendict.core.frozendict
to correctly depickle as the native implementation in the future on python 3.11.The second implements the fix for #87.