Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] frozendict.deepfreeze is not in __init__.pyi #99

Closed
jclerman opened this issue May 3, 2024 · 4 comments
Closed

[BUG] frozendict.deepfreeze is not in __init__.pyi #99

jclerman opened this issue May 3, 2024 · 4 comments
Labels
Effort: Low easy task Needs: Test Hey, it compiles! Ship it! Priority: Low Not a big problem... Type: Enhancement New feature or request

Comments

@jclerman
Copy link

jclerman commented May 3, 2024

My IDE complains that frozendict.deepfreeze() is not advertised in __init__.pyi.

  • OS version: MacOS 13.6.6
  • Python3 version (python3 -V -V):
    Python 3.10.12 (main, Aug 16 2023, 12:57:33) [Clang 14.0.0 (clang-1400.0.29.202)]

Steps to reproduce:

  1. In PyCharm, write code that accesses the deepfreeze function, like:
import deepfreeze

def temp(x):
    return frozendict.deepfreeze(x)

Actual result:
I get a warning flagged in PyCharm (even though the code runs fine):

image

@jclerman
Copy link
Author

jclerman commented May 4, 2024

NOTE: This also causes mypy to complain thusly:

error: Module has no attribute "deepfreeze"  [attr-defined]

@Marco-Sulla Marco-Sulla added Type: Enhancement New feature or request Priority: Low Not a big problem... Effort: Low easy task Needs: Test Hey, it compiles! Ship it! labels May 4, 2024
@Marco-Sulla
Copy link
Owner

Marco-Sulla commented May 5, 2024

ty for the issue. Fixed in 2.4.34

@jclerman
Copy link
Author

jclerman commented May 6, 2024

Thanks for the quick fix!!

By the way, when looking into how this was done I happened upon this notice from GitHub. Not sure if it's worth fixing - looks like maybe the tag was applied to a deleted branch instead of to the main branch?

image

@Marco-Sulla
Copy link
Owner

I have done some mess with the push. I don't know what happened in detail. Anyway, it seems that 2.4.3 contains only the fix of enum with deepfreeze. I just released 2.4.4, that now contains the fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Low easy task Needs: Test Hey, it compiles! Ship it! Priority: Low Not a big problem... Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants