Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Action to Node 16 #37

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Bump Action to Node 16 #37

merged 1 commit into from
Jan 17, 2023

Conversation

kkaulen
Copy link
Contributor

@kkaulen kkaulen commented Nov 25, 2022

Update the Action to work with Node.js 16. Current Action runs on Node.js 12 and leads to deprecation warnings in workflows that use the action.

All tests pass and i tested my fork in a private monorepo and everythink works like a charm.

Closes #36

@gurudatta-carbon
Copy link

@MarceloPrado possible to merge this change ?

@MarceloPrado
Copy link
Owner

Yes! And sorry for the delay! Will merge and release a new version

@MarceloPrado MarceloPrado merged commit df1b7a3 into MarceloPrado:master Jan 17, 2023
@gurudatta-carbon
Copy link

@MarceloPrado was this published to marketplace ?
still getting same error

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: marceloprado/has-changed-path@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

@MarceloPrado
Copy link
Owner

@gurudatta-carbon yes, you can see the release here: https://github.com/MarceloPrado/has-changed-path/releases/tag/v1.0.1

Did you try bumping the version number?

@gurudatta-carbon
Copy link

gurudatta-carbon commented Jan 23, 2023

Did you try bumping the version number?

shouldn't @v1 or @v1.0 should get the latest version ? 💭

we are using @v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 12 actions are deprecated
3 participants