cmake: add USE_SYSTEM_* options; support find_package(FXdiv)#5
Open
ConnorBaker wants to merge 1 commit intoMaratyszcza:masterfrom
Open
cmake: add USE_SYSTEM_* options; support find_package(FXdiv)#5ConnorBaker wants to merge 1 commit intoMaratyszcza:masterfrom
ConnorBaker wants to merge 1 commit intoMaratyszcza:masterfrom
Conversation
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
8 times, most recently
from
2c22a0d to
78694ed
Compare
ConnorBaker
changed the title
42 tasks
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
2 times, most recently
from
49c78c9 to
4cf8ddc
Compare
ConnorBaker
commented
Jul 3, 2023
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
from
4cf8ddc to
1ab1650
Compare
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
3 times, most recently
from
70893e2 to
9e916ec
Compare
Author
|
Updated to reflect comment from pytorch/cpuinfo#153 (comment). @Maratyszcza if you have the time, would you mind reviewing this? |
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
from
9e916ec to
e894fbb
Compare
|
I'd be interested in seeing this merged as well since we need this change for the https://github.com/google/ml-compiler-opt project. @Maratyszcza would it be possible to take a look? |
|
Bumping this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the work done in pytorch/pytorch#37137, this adds the following CMake options:
USE_SYSTEM_LIBSUSE_SYSTEM_GOOGLEBENCHMARKUSE_SYSTEM_GOOGLETESTThis is particularly useful in the context of Nix, where we can build these libraries once and then re-use them elsewhere to avoid rebuilding vendors dependencies.
Additionally, adds a CMake configuration file to make it possible for CMake-based projects to use
find_packageto consume this library.