cmake: add FP16_USE_SYSTEM_* options; support find_package(FP16)#23
Open
ConnorBaker wants to merge 1 commit intoMaratyszcza:masterfrom
Open
cmake: add FP16_USE_SYSTEM_* options; support find_package(FP16)#23ConnorBaker wants to merge 1 commit intoMaratyszcza:masterfrom
ConnorBaker wants to merge 1 commit intoMaratyszcza:masterfrom
Conversation
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
from
5dccba0 to
4cf7593
Compare
42 tasks
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
from
4cf7593 to
7728c93
Compare
ConnorBaker
changed the title
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
5 times, most recently
from
2740616 to
a2e21c1
Compare
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
7 times, most recently
from
c999011 to
86814cd
Compare
Author
|
Updated to reflect comment from pytorch/cpuinfo#153 (comment). @Maratyszcza if you have the time, would you mind reviewing this? |
|
@Maratyszcza Hi Marat, this would make the life of barebone packagers much easier. Please merge it! |
Maratyszcza
force-pushed
the
master
branch
11 times, most recently
from
abf58f5 to
8d5f685
Compare
Maratyszcza
force-pushed
the
master
branch
17 times, most recently
from
5c38e5d to
5933328
Compare
|
@ConnorBaker any chance you can give me read/write permissions to the repo? would love to sync upstream |
|
@ConnorBaker thanks! Looks like I need permission to push to your branch |
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
from
86814cd to
82fdc40
Compare
Signed-off-by: Connor Baker <ConnorBaker01@gmail.com>
ConnorBaker
force-pushed
the
feat/use-system-libs
branch
from
82fdc40 to
ce77093
Compare
Author
|
@BwL1289 I saw the same error when viewing your PR; not sure why that came up. I've rebased on the latest and force-pushed and changed the names to have a |
ConnorBaker
changed the title
|
Thanks @ConnorBaker! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the work done in pytorch/pytorch#37137, this adds the following CMake options:
FP16_USE_SYSTEM_LIBSFP16_USE_SYSTEM_GOOGLEBENCHMARKFP16_USE_SYSTEM_GOOGLETESTThis is particularly useful in the context of Nix, where we can build these libraries once and then re-use them elsewhere to avoid rebuilding vendors dependencies.
Additionally, adds a CMake configuration file to make it possible for CMake-based projects to use
find_packageto consume this library.