Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setTheme dynamic require(...) that is problematic with webpack #203

Merged
merged 2 commits into from
Feb 16, 2018
Merged

Remove setTheme dynamic require(...) that is problematic with webpack #203

merged 2 commits into from
Feb 16, 2018

Commits on Sep 29, 2017

  1. Remove setTheme dynamic require(...) that is problematic with webpack

    @jpap
    jpap committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    c018e0b View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. Update colors.js 

    Setting a theme using a dynamic require is bad practice and causes lots of problems.  In case anyone is using that "feature," though, we return a warning that very explicitly tells them the (very simple) change they need to make to their code.
    @DABH
    DABH authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    0da00b2 View commit details
    Browse the repository at this point in the history