Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider applying NameMatchingStrategy(NameMatchingStrategy.Flexible) to Dictionary<->Object mapping #63

Closed
kellyethridge opened this issue May 11, 2016 · 2 comments
Closed

Consider applying NameMatchingStrategy(NameMatchingStrategy.Flexible) to Dictionary<->Object mapping #63

kellyethridge opened this issue May 11, 2016 · 2 comments
Labels
feature request

Comments

@kellyethridge
Copy link

Hello,

From what I can tell, the name matching strategy is only applied between two objects. It would be a big benefit for Dictionary<->Object mapping, especially when using PATCH methods in WebApi since json property names are usually camel-case/snake-case while classes are usually Pascal.
@chaowlert
Copy link
Collaborator

Yeah true, we should also apply name matching to dictionary.

@chaowlert
Copy link
Collaborator

Note: for performance reason, I added 2 strategies
NameMappingStrategy.ToCamelCase is for Object to Dictionary
NameMappingStrategy.FromCamelCase is for Dictionary to Object

NameMappingStrategy.Flexible is also working, but performance might be low.

kellyethridge pushed a commit to kellyethridge/Mapster that referenced this issue Oct 1, 2016
@chaowlert @kellyethridge
fix MapsterMapper#63 apply NameMatchingStrategy to object dictionary …
bab7cd1 
…mapping
kellyethridge pushed a commit to kellyethridge/Mapster that referenced this issue Nov 13, 2017
@chaowlert @kellyethridge
fix MapsterMapper#63 apply NameMatchingStrategy to object dictionary …
0e364ae 
…mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kellyethridge @chaowlert