-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Critical regression introduced in Mapster 7.3.0 when mapping to existing objects #537
Comments
Hello. In this case, should not be version 7.3.0 marked as deprecated because of critical bugs in nuget.org? |
hi, is there any progress? |
Hello, new instanse always created if TDestination does not have a public constructor without parameters. Maybe this has something to do with the problem. Class is detected as Record in Mapster/src/Mapster/Utils/ReflectionUtils.cs Line 161 in 04ac871
|
not fix - collection issue MapsterMapper#430 MapsterMapper#546 - object to ToDistination MapsterMapper#524
Thanks to @DocSvartz this issue has been partially fixed. See #634 for details. |
Hello @andrerav , have you had problems with dictionaries ? |
There are numerous issues that have been reported since the release of 7.3.0 that seem to have a common theme -- performing a map to an existing object has a tendency to create a new object instance instead of preserving the instance being mapped. So far it seems that the following issues have reported this:
Other possibly related issues:
I'm working on investigating which chance in 7.3.0 that might have introduced this issue. I will update this issue when I have new information to share.
The text was updated successfully, but these errors were encountered: