Skip to content

Prevent PDF uploads from freezing on parser panics #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnthonyRonning wants to merge 2 commits into from
Closed

Prevent PDF uploads from freezing on parser panics #653

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0274ce
fix: harden PDF extraction against parser panics
AnthonyRonning Jul 20, 2026
8a9cfe2
fix: harden PDF extraction edge cases
AnthonyRonning Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Preserve vendored crate bytes while excluding upstream whitespace from checks.
frontend/src-tauri/patches/pdf-extract-0.12.0/** -whitespace

# PDF xref tables contain byte-offset-sensitive, fixed-width records.
frontend/src-tauri/tests/fixtures/*.pdf binary
88 changes: 74 additions & 14 deletions frontend/src-tauri/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion frontend/src-tauri/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ maple-proxy = "0.2.0"
tauri-plugin-fs = "2.5.1"
anyhow = "1.0"
axum = "0.8"
pdf-extract = "0.7"
pdf-extract = "=0.12.0"
base64 = "0.22"

[target.'cfg(any(target_os = "macos", target_os = "windows"))'.dependencies]
Expand Down Expand Up @@ -111,6 +111,10 @@ keyring = { version = "3", features = ["windows-native"] }
windows = { version = "0.62.2", features = ["Win32_System_Threading"] }

[patch.crates-io]
# Carry narrowly scoped fixes for known pdf-extract 0.12 text-decoding
# regressions and remove user-controlled Type 4 function contents from logs.
pdf-extract = { path = "patches/pdf-extract-0.12.0" }

# Local patch for tao 0.35.2 Android intent crashes:
# https://github.com/tauri-apps/tao/issues/1217
#
Expand Down
Loading
Loading