Fix Windows Tauri signing order #584
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| $ErrorActionPreference = "Stop" | ||
| Set-StrictMode -Version 3.0 | ||
|
|
||
| $moduleName = "ArtifactSigning" | ||
| $moduleVersion = "0.1.8" | ||
| $moduleSha256 = "3221344b8c627915d3870f23e80816f31a5d8c2bae1d7c0cdd6c9652f6c4e089" | ||
| $moduleUrl = "https://www.powershellgallery.com/api/v2/package/$moduleName/$moduleVersion" | ||
|
|
||
| if ([string]::IsNullOrWhiteSpace($env:RUNNER_TEMP)) { | ||
| $baseTemp = [System.IO.Path]::GetTempPath() | ||
| } else { | ||
| $baseTemp = $env:RUNNER_TEMP | ||
| } | ||
|
|
||
| $moduleRoot = Join-Path $baseTemp "maple-powershell-modules" | ||
| $moduleDir = Join-Path $moduleRoot "$moduleName/$moduleVersion" | ||
| $downloadDir = Join-Path $baseTemp "maple-powershell-downloads" | ||
| $packagePath = Join-Path $downloadDir "$moduleName.$moduleVersion.nupkg" | ||
|
|
||
| New-Item -ItemType Directory -Force -Path $downloadDir | Out-Null | ||
| New-Item -ItemType Directory -Force -Path $moduleRoot | Out-Null | ||
|
|
||
| Invoke-WebRequest -Uri $moduleUrl -OutFile $packagePath -TimeoutSec 120 | ||
|
|
||
| $actualSha256 = (Get-FileHash -Algorithm SHA256 -LiteralPath $packagePath).Hash.ToLowerInvariant() | ||
| if ($actualSha256 -ne $moduleSha256) { | ||
| throw "$moduleName $moduleVersion hash mismatch. Expected $moduleSha256 but got $actualSha256." | ||
| } | ||
|
|
||
| if (Test-Path -LiteralPath $moduleDir) { | ||
| Remove-Item -LiteralPath $moduleDir -Recurse -Force | ||
| } | ||
| New-Item -ItemType Directory -Force -Path $moduleDir | Out-Null | ||
| Expand-Archive -LiteralPath $packagePath -DestinationPath $moduleDir -Force | ||
|
|
||
| $manifestPath = Join-Path $moduleDir "$moduleName.psd1" | ||
| Import-Module -Name $manifestPath -Force -ErrorAction Stop | ||
| $loadedModule = Get-Module $moduleName | Where-Object { $_.Version -eq [version]$moduleVersion } | Select-Object -First 1 | ||
| if (-not $loadedModule) { | ||
| throw "$moduleName $moduleVersion was not loaded from $manifestPath." | ||
| } | ||
| if (-not (Get-Command Invoke-ArtifactSigning -ErrorAction SilentlyContinue)) { | ||
| throw "Invoke-ArtifactSigning was not exported by $manifestPath." | ||
| } | ||
|
|
||
| if (-not [string]::IsNullOrWhiteSpace($env:GITHUB_ENV)) { | ||
| "MAPLE_WINDOWS_ARTIFACT_SIGNING_MODULE_ROOT=$moduleRoot" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8 | ||
| if ([string]::IsNullOrWhiteSpace($env:PSModulePath)) { | ||
| "PSModulePath=$moduleRoot" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8 | ||
| } else { | ||
| "PSModulePath=$moduleRoot;$env:PSModulePath" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8 | ||
| } | ||
| } | ||
|
|
||
| Write-Host "$moduleName $moduleVersion installed with verified SHA-256 $moduleSha256" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| param( | ||
| [Parameter(Mandatory = $true)] | ||
| [string]$File | ||
| ) | ||
|
|
||
| $ArtifactSigningVersion = "0.1.8" | ||
|
|
||
| $ErrorActionPreference = "Stop" | ||
| Set-StrictMode -Version 3.0 | ||
|
|
||
| if (-not (Test-Path -LiteralPath $File -PathType Leaf)) { | ||
| throw "Windows artifact to sign was not found: $File" | ||
| } | ||
|
|
||
| $requiredEnv = @( | ||
| "MAPLE_WINDOWS_ARTIFACT_SIGNING_ENDPOINT", | ||
| "MAPLE_WINDOWS_ARTIFACT_SIGNING_ACCOUNT_NAME", | ||
| "MAPLE_WINDOWS_ARTIFACT_SIGNING_CERTIFICATE_PROFILE_NAME" | ||
| ) | ||
|
|
||
| foreach ($name in $requiredEnv) { | ||
| if ([string]::IsNullOrWhiteSpace([Environment]::GetEnvironmentVariable($name))) { | ||
| throw "$name is required for Windows Artifact Signing." | ||
| } | ||
| } | ||
|
|
||
| $moduleRoot = $env:MAPLE_WINDOWS_ARTIFACT_SIGNING_MODULE_ROOT | ||
| if (-not [string]::IsNullOrWhiteSpace($moduleRoot)) { | ||
| $moduleManifest = Join-Path $moduleRoot "ArtifactSigning/$ArtifactSigningVersion/ArtifactSigning.psd1" | ||
| if (-not (Test-Path -LiteralPath $moduleManifest -PathType Leaf)) { | ||
| throw "ArtifactSigning module manifest was not found: $moduleManifest" | ||
| } | ||
| Import-Module -Name $moduleManifest -Force -ErrorAction Stop | ||
| } else { | ||
| Import-Module ArtifactSigning -RequiredVersion $ArtifactSigningVersion -ErrorAction Stop | ||
| } | ||
|
|
||
| $loadedModule = Get-Module ArtifactSigning | Where-Object { $_.Version -eq [version]$ArtifactSigningVersion } | Select-Object -First 1 | ||
| if (-not $loadedModule) { | ||
| throw "ArtifactSigning $ArtifactSigningVersion was not loaded." | ||
| } | ||
|
|
||
| $params = @{ | ||
| Endpoint = $env:MAPLE_WINDOWS_ARTIFACT_SIGNING_ENDPOINT | ||
| CodeSigningAccountName = $env:MAPLE_WINDOWS_ARTIFACT_SIGNING_ACCOUNT_NAME | ||
| CertificateProfileName = $env:MAPLE_WINDOWS_ARTIFACT_SIGNING_CERTIFICATE_PROFILE_NAME | ||
| Files = $File | ||
| FileDigest = "SHA256" | ||
| TimestampRfc3161 = "http://timestamp.acs.microsoft.com" | ||
| TimestampDigest = "SHA256" | ||
| ExcludeEnvironmentCredential = $true | ||
| ExcludeWorkloadIdentityCredential = $true | ||
| ExcludeManagedIdentityCredential = $true | ||
| ExcludeSharedTokenCacheCredential = $true | ||
| ExcludeVisualStudioCredential = $true | ||
| ExcludeVisualStudioCodeCredential = $true | ||
| ExcludeAzureCliCredential = $false | ||
| ExcludeAzurePowerShellCredential = $true | ||
| ExcludeAzureDeveloperCliCredential = $true | ||
| ExcludeInteractiveBrowserCredential = $true | ||
| } | ||
|
Comment on lines
+43
to
+61
Contributor
There was a problem hiding this comment. 🚩 Module parameter names mapped from GitHub Action input names to PowerShell cmdlet parameters The old GitHub Action used kebab-case input names (e.g., 
Was this helpful? React with 👍 or 👎 to provide feedback. |
||
|
|
||
| Invoke-ArtifactSigning @params | ||
|
|
||
| Write-Host ("signed-windows-artifact {0}" -f (Split-Path -Leaf $File)) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Keep verifying the patched app executable after bundling.
Line 89 and Line 103 now verify only the NSIS setup. Since the app exe is the artifact Tauri mutates and
signCommandis expected to sign, verify${app_exe}after bundling as well; otherwise a signed installer can ship an unsigned or wrong-subject installed executable.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents