Move tests from nbs_tests/constants to pytest format #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converted tests from Jupyter notebooks to pytest format - Added proper fixtures to handle test isolation - Added module-level teardown functions to restore global state
|
Finally, thank you Georg! And Claude? |
|
This was a test for claude code. There was no manual work involved :D |
|
could we point this to |
|
and should we remove the source notebooks? (given that they don't contain any content except those tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need your help moving tests from jupyter notebooks to pytest.
There are already existing pytest tests, use the same pattern.
If you want to run tests, use the alpha conda env.
Do not add new assert statemnts or remove other ones. Copy the tests and adapt them to pytest using fixtures etc..
only move: /Users/georgwallmann/Documents/git/alphabase/nbs_tests/constants