Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on nightly #266

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix build on nightly #266

merged 1 commit into from
Apr 27, 2023

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Apr 27, 2023 •
edited
Loading

(meant to send this to my own fork, but here it is)

This finally fixes the nightly build.

Manishearth
Manishearth approved these changes Apr 27, 2023
View reviewed changes
Copy link
Owner

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that split happened ages ago

Thanks!

@tamird
Copy link
Contributor Author

tamird commented Apr 27, 2023 •
edited
Loading

Would you mind cutting a release after this merges? I'd like to use #263 in https://github.com/aya-rs/bpf-linker.

@Manishearth Manishearth merged commit 918b082 into Manishearth:master Apr 27, 2023
@Manishearth
Copy link
Owner

Sure, make a PR with a minor version bump

@tamird tamird deleted the fix-nightly-build-again branch September 5, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamird @Manishearth