Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider callsite of macro expansions #116

Closed
wants to merge 2 commits into from
Closed

Consider callsite of macro expansions #116

wants to merge 2 commits into from

Conversation

fpoli
Copy link
Contributor

@fpoli fpoli commented Jun 27, 2018

This fixes #48

In case of macros, the correct span to look at is the one that corresponds to the call site.

@laumann
Copy link
Collaborator

laumann commented Jun 27, 2018

Thanks! Is this something that can be pushed to rustc/compiletest?

@fpoli
Copy link
Contributor Author

fpoli commented Jun 27, 2018

I'll check

@fpoli fpoli mentioned this pull request Jun 27, 2018
Closed
@laumann
Copy link
Collaborator

laumann commented Jun 28, 2018

Thanks

@fpoli
Copy link
Contributor Author

fpoli commented Jul 20, 2018

I close this PR: the one in rustc is strictly better (rust-lang/rust#52175)

@fpoli fpoli closed this Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0 unexpected errors
2 participants
@fpoli @laumann