Skip to content

Fix DeprecationWarning on method Thread.setDaemon #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manishearth merged 1 commit into from
May 21, 2024
Merged

Fix DeprecationWarning on method Thread.setDaemon #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chatexchange/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ def start(self):
name="ChatExchange: RoomSocketWatcher for room #{}".format(
self.room_id),
target=self._runner)
self.thread.setDaemon(True)
self.thread.daemon = True
self.thread.start()

def _runner(self):
Expand Down Expand Up @@ -778,7 +778,7 @@ def start(self):
name="ChatExchange: RoomPollingWatcher for room #{}".format(
self.room_id),
target=self._runner)
self.thread.setDaemon(True)
self.thread.daemon = True
self.thread.start()

def close(self):
Expand Down
2 changes: 1 addition & 1 deletion chatexchange/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def __init__(
self._recently_gotten_objects = collections.deque(maxlen=self._max_recently_gotten_objects)
self._requests_served = 0
self._thread = threading.Thread(target=self._worker, name="ChatExchange: message_sender for chat.{}".format(host))
self._thread.setDaemon(True)
self._thread.daemon = True

self.aggressive_sender = send_aggressively

Expand Down