forked from Casecommons/pg_search
-
Notifications
You must be signed in to change notification settings - Fork 1
Update from upstream #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for more more advanced columns, for example, extracting elements out of json arrays, or fields out of json objects. Resolve Casecommons#252 Signed-off-by: Kyle Fazzari <[email protected]>
column: add support for Arel::Nodes::SqlLiteral
Fix readme typo
Authored-by: Grant Hutchins <[email protected]>
Run tests against Ruby 3.3 preview
Run tests against Ruby 3.3 release candidate
Run tests against Ruby 3.3
Ruby 2.7 has been EOL since 2023-03-31
Active Record 6.0 has been EOL since 2023-06-01
Signed-off-by: Grant Hutchins <[email protected]>
Fix compatibility with ActiveRecord 7.2
There's no need to introduce the ostruct stdlib gem just for this single object while testing. This removes a warning about including a stdlib gem without explicitly depending on it.
…pendency Replace ostruct dependency with RSpec double
3ed9aa6 to
a8f5fdb
Compare
wiscoDude
approved these changes
Oct 31, 2024
wiscoDude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.