Update nokogiri to 1.8.5 ~ CVE-2018-14404 #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of nokogiri (1.5) is vulnerable for
CVE-2018-14404
andCVE-2018-14567
.A solution for that is update the nokogiri version to
1.8.5
where this fix was already implemented.References:
sparklemotion/nokogiri#1785
https://rubysec.com/advisories/nokogiri-CVE-2018-14404
UPD: Ruby with versions
2.1
and2.2
are not supported by bundle version 2+, so I specified the exact version in the travis.ci for the build to be working. Also,gem update --system
seems not be needed anymore for ruby version2.5.0
.cc @Mange