Introducing embedded_workflow to dynamic select box in service dialogs #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2023
Member
|
EDIT: Builds are working now after #473 |
Fryguy
reviewed
Jul 5, 2023
| <div pf-form-group pf-label="Automation Type" class="entry_point_selector_types"> | ||
| <select class="form-control" miq-select ng-model="vm.modalData.automation_type" ng-change="vm.treeOptions.onAutomationTypeChange()"> | ||
| <option value="{{vm.treeOptions.automationTypes.automate}}" translate>Embedded Automate</option> | ||
| <option value="{{vm.treeOptions.automationTypes.workflow}}" translate>Embedded Workflows</option> |
Member
There was a problem hiding this comment.
We probably should only show this if the prototype flag is enabled. This can be found via API.
jeffibm
force-pushed
the
dialog-workflow-options
branch
3 times, most recently
from
b17ac1e to
e43627c
Compare
jeffibm
force-pushed
the
dialog-workflow-options
branch
from
3dadda5 to
ed21527
Compare
Member
|
Checked commit jeffbonson@ed21527 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Member
|
@DavidResende0 or @GilbertCherrie could you review this as well? |
DavidResende0
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots in related PR - ManageIQ/manageiq-ui-classic#8844