Provide backward compatible way to globally set permitted classes #22887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed in rails 7 in the following commit: rails/rails@9529dc8 Note, there are ways to do per model permitted classes in rails 7.1, see: rails/rails@4a07553
Closed
Member
|
Checked commit jrafanie@281c416 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
Feb 7, 2024
jrafanie
deleted the
yaml_column_permitted_classes_rails_7_backward_compatible
branch
jrafanie
added a commit
to jrafanie/manageiq-providers-openstack
that referenced
this pull request
Jun 28, 2024
This supports rails 7 and 6.1. Similar to the change in: ManageIQ/manageiq#22887
jrafanie
added a commit
to jrafanie/manageiq-providers-kubernetes
that referenced
this pull request
Jun 28, 2024
This supports rails 7 and 6.1. Similar to the change in: ManageIQ/manageiq#22887
jrafanie
added a commit
to jrafanie/manageiq-ui-classic
that referenced
this pull request
Jun 28, 2024
This supports rails 7 and 6.1. Similar to the change in: ManageIQ/manageiq#22887
jrafanie
added a commit
to jrafanie/manageiq-ui-classic
that referenced
this pull request
Jun 28, 2024
This supports rails 7 and 6.1. Similar to the change in: ManageIQ/manageiq#22887
Dhamo1107
pushed a commit
to Dhamo1107/manageiq-ui-classic
that referenced
this pull request
Jul 23, 2024
…atalog items and removed the duplicate column of vault credentials. Fixed the bug where vault credentials were not appearing in service catalog items and removed the duplicate column of vault credentials. Remove current workflow state if its done Fix guest devices summary page show volume templates in image list view Fix survey table readability Update Workflow State icons Before ====== Icons were working for Tasks Icons were only displaying play for all others After ===== Icons are displaying for all Tasks Updated UI json for May 31st translations From ManageIQ/manageiq#23057 and ManageIQ/manageiq#22969 Update .whitesource to trigger a Mend run Update lodash to 4.17.12 Hide policy simulation button Bump ws from 5.2.3 to 5.2.4 Bumps [ws](https://github.com/websockets/ws) from 5.2.3 to 5.2.4. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@5.2.3...5.2.4) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Update Yarn to v4.3.0 Fix child services link Update yarn.lock with latest dependencies Update Yarn to v4.3.1 Prepend ActionView::Helpers::NumberHelper with our NumberHelper Fix request form automation fields Update all carbon packages update moment to 2.29.2 through resolution Fix failing automate specs Add known pending package security issues to a pending list Resolve ActionView::MissingTemplate errors by specifying template Rails 7 now raises this error if you don't specify the template correctly. Specifying templates with "." in the name was deprecated here: https://www.github.com/rails/rails/pull/39164 The interface they want is without periods and for you to specify the formats if it's non-standard. Also, render with no :template, :partial, etc. is also gone in rails 7. Somewhat related issued with helpful information can be found here: https://www.github.com/mileszs/wicked_pdf/issues/1005 Remove redundant tests: we check for these in the response body already Provide backward compatible way to globally set permitted classes This supports rails 7 and 6.1. Similar to the change in: ManageIQ/manageiq#22887 add annotations on summary pages with labels and fix miq_custom_attributes Fix variable table spacing Added existing search bar React component in Cloud Tenant module Fixed rubocop error
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Aug 6, 2024
Drops the rails 6.1 compatibility from: ManageIQ#22887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed in rails 7 in the following commit:
rails/rails@9529dc8
Note, there are ways to do per model permitted classes in rails 7.1, see: rails/rails@4a07553
Extracted from #22873