Skip to content

Conversation

@GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Oct 28, 2025

Follow up to this pr: #9632

This PR removes the text and only shows the icon in the payload valid column.

Before:
Screenshot 2025-10-28 at 12 37 40 PM

After:
Screenshot 2025-10-28 at 12 37 05 PM

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner October 28, 2025 16:36
@agrare agrare self-assigned this Oct 28, 2025
@agrare agrare merged commit 0ee52c8 into ManageIQ:master Oct 28, 2025
19 checks passed
@GilbertCherrie GilbertCherrie deleted the workflow_table_remove_icon_text branch October 28, 2025 17:13
@Fryguy
Copy link
Member

Fryguy commented Oct 28, 2025

@GilbertCherrie Does this have alt/hover text that says true/false? Just want to make sure that it's still accessible.

@GilbertCherrie
Copy link
Member Author

@Fryguy no we would need to add this if we wanted it

@Fryguy
Copy link
Member

Fryguy commented Oct 28, 2025

I think we have to - a bare icon breaks accessibility.

@GilbertCherrie
Copy link
Member Author

@Fryguy sorry it looks like it does have it already
Screenshot 2025-11-06 at 4 58 19 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants