Update Workflow State icons

[kbrock]

Before

Icons were working for Tasks
Icons were only displaying play for all others

After

Icons are displaying for all Tasks

[kbrock]

update:

• removed commented out code

[Fryguy]

What are the TODO for?

[Fryguy]

Don't think we need this tooltip.

[agrare]

@kbrock do you have a TLDR for why it wasn't working before? What was it about tasks that was causing it to work? I'm assuming it is because it used to check for RunnerContext but just making sure that's what the real issue was

[Fryguy]

tooltip wise, I'm concerned the error will be too big for a tooltip. If there is no error, will it show : 4? Also there's no indicator that the trailing number is the retry count.

[Fryguy]

@kbrock Can we take out the tooltip stuff and do that in a separate PR? I think fixing the icons can be it's own thing.

[Fryguy]

Again, can we remove the tooltips / titles entirely from this PR? I'd like to merge the bug fix separate from the enhancement.

I'm good with the new icon for retry failed.

[kbrock]

@agrare we were looking at State.RunnerContext.Error. Now were looking at State.Error (and friends)
@Fryguy All set now

update:

• removed s/yay/boo/g
• added tooltips
• removed TODOs

update:

• fixed color for retry
• removed tooltips (sorry - missed you in flight)

/paired with @GilbertCherrie

---

Dev notes:

        let title = item.Output.Cause ? `${item.Output.Error} : ${item.Output.Cause}` : item.Output.Error;
        if (title.length > 100) {
          title = title.substring(0, 100)
        }
        const title = sprintf(__(`Retry Count: %d`), item.RetryCount);

[kbrock]

wip: I need to test the just failing case.

Think the retry logic should be bubbled up one level.
Quickly checking and will be all set to merge soon

[miq-bot]

Checked commit kbrock@bbf70d8 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

[kbrock]

update:

• fixed: failures now display as failure (was success)
• fixed: retry successes now displays as success (was displaying as a failure)

un-wip: resolved

[Fryguy]

Backported to radjabov in commit 0301d74.

commit 0301d74f503a42cd2f730a3d42c60ab0ebcced15
Author: Adam Grare <adam@grare.com>
Date:   Wed Jun 5 10:28:14 2024 -0400

    Merge pull request #9200 from kbrock/state_logos
    
    Update Workflow State icons
    
    (cherry picked from commit e5d7cb22689b581662a09917a24006167f247a4c)