Skip to content

Fix guest devices summary page #9197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

Fix guest devices summary page #9197

merged 1 commit into from
May 29, 2024

Conversation

@GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented May 28, 2024 •
edited
Loading

Fixed guest devices summary page. Fixed the issue with the breadcrumbs missing and the print summary button not working.

Before:
Screenshot 2024-05-28 at 2 05 56 PM
Screenshot 2024-05-28 at 2 07 14 PM

After:
Screenshot 2024-05-28 at 2 09 29 PM
Screenshot 2024-05-28 at 2 08 24 PM

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner May 28, 2024 18:01
@miq-bot
Copy link
Member

miq-bot commented May 28, 2024

Checked commit GilbertCherrie@322c5f6 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy
Copy link
Member

Fryguy commented May 28, 2024

@jeffibm Please review.

@jeffbonson jeffbonson merged commit 2d008c5 into ManageIQ:master May 29, 2024
@Fryguy
Copy link
Member

Fryguy commented May 29, 2024

Backported to radjabov in commit fb2bbbe.

commit fb2bbbeadd6bbad065bd31ba9d996675639a0e2d
Author: Jeffrey bonson <[email protected]>
Date:   Wed May 29 08:42:48 2024 +0530

    Merge pull request #9197 from GilbertCherrie/fix_guest_devices_summary_page
    
    Fix guest devices summary page
    
    (cherry picked from commit 2d008c5bf84ba47f4127b9cf051877e7578c7d24)

Fryguy pushed a commit that referenced this pull request May 29, 2024
@jeffbonson @Fryguy
Merge pull request #9197 from GilbertCherrie/fix_guest_devices_summar…
fb2bbbe 
…y_page

Fix guest devices summary page

(cherry picked from commit 2d008c5)
@GilbertCherrie GilbertCherrie deleted the fix_guest_devices_summary_page branch May 29, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeffbonson jeffbonson jeffbonson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeffibm jeffibm

Labels

bug radjabov/backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GilbertCherrie @miq-bot @Fryguy @jeffbonson @jeffibm