Remove current workflow state if its done

[GilbertCherrie]

Follow up to pr: #9191

When the current state is done its value is not removed from the context.State but also exists in the context.StateHistory. This pr prevents this state from rendering in the table as both a past state and current state and instead will only render it as a past state.

Before:

After:

[Fryguy]

As discussed in #9191 (comment), I don't think we can use id because they aren't unique.

Re-asking here: @agrare One more question. When the entire flow is done, does the "current" state have a "finished time"? If so, that might be the simplest check.

[agrare]

One more question. When the entire flow is done, does the "current" state have a "finished time"? If so, that might be the simplest check.

Yes,

   "State"=>
    {"Name"=>"NextState",
     "Input"=>{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}},
     "Guid"=>"81de8e05-8118-49d0-b97e-779904fb07c3",
     "EnteredTime"=>"2024-05-24T14:34:29Z",
     "Output"=>{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}},
     "NextState"=>nil,
     "FinishedTime"=>"2024-05-24T14:34:29Z",
     "Duration"=>0.348082391}

[Fryguy]

@GilbertCherrie So, I think the path forward, is when you check for the presence of State, simply also check that FinishedTime is not present.

[Fryguy]

So basically, something like the following (not sure this works, but you get the idea)

Suggested change

	if (response.context && response.context.State) {
	if (response.context && response.context.State && !response.context.State.FinishedTime) {) {

[Fryguy]

and then of course you don't need any of the other changes.

[GilbertCherrie]

Sounds good, made the fix and repushed

[GilbertCherrie]

@Fryguy I made the fix to check for the FinishedTime

[miq-bot]

Checked commit GilbertCherrie@635dbcc with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

[Fryguy]

Backported to radjabov in commit cf3f4c0.

commit cf3f4c08fa463b2b3869e6d33afe4b0dc0df931d
Author: Jason Frey <[email protected]>
Date:   Fri May 24 17:25:52 2024 -0400

    Merge pull request #9195 from GilbertCherrie/remove_current_workflow_state
    
    Remove current workflow state if its done
    
    (cherry picked from commit ecce83550d0f9f6cd81df5a0ffe5a80a5229dd3b)