Skip to content

Conversation

@jeffibm
Copy link
Member

@jeffibm jeffibm commented May 6, 2024

yarn run jest -t 'Show Edit Host Form Component' --testPathPattern app/javascript/spec/host-edit-form/host-edit-form.spec.js

Before

 PASS  app/javascript/spec/host-edit-form/host-edit-form.spec.js
  Show Edit Host Form Component
    ✓ should render form for *one* host (233ms)
    ✓ should render form for multiple hosts (28ms)

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to AsyncCredentials inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in AsyncCredentials (created by ValidateHostCredentials)
        in ValidateHostCredentials (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by Tabs)
        in div (created by Tabs)
        in div (created by TabContent)
        in TabContent (created by Tabs)
        in Tabs (created by Tabs)
        in Tabs (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by SubForm)
        in div (created by SubForm)
        in SubForm (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by HostEditForm)
        in HostEditForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to AsyncCredentials inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in AsyncCredentials (created by ValidateHostCredentials)
        in ValidateHostCredentials (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by Tabs)
        in div (created by Tabs)
        in div (created by TabContent)
        in TabContent (created by Tabs)
        in Tabs (created by Tabs)
        in Tabs (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by SubForm)
        in div (created by SubForm)
        in SubForm (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by HostEditForm)
        in HostEditForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to AsyncCredentials inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in AsyncCredentials (created by ValidateHostCredentials)
        in ValidateHostCredentials (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by Tabs)
        in div (created by Tabs)
        in div (created by TabContent)
        in TabContent (created by Tabs)
        in Tabs (created by Tabs)
        in Tabs (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by SubForm)
        in div (created by SubForm)
        in SubForm (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by HostEditForm)
        in HostEditForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to AsyncCredentials inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in AsyncCredentials (created by ValidateHostCredentials)
        in ValidateHostCredentials (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by Tabs)
        in div (created by Tabs)
        in div (created by TabContent)
        in TabContent (created by Tabs)
        in Tabs (created by Tabs)
        in Tabs (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by SubForm)
        in div (created by SubForm)
        in SubForm (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by HostEditForm)
        in HostEditForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to AsyncCredentials inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in AsyncCredentials (created by ValidateHostCredentials)
        in ValidateHostCredentials (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by Tabs)
        in div (created by Tabs)
        in div (created by TabContent)
        in TabContent (created by Tabs)
        in Tabs (created by Tabs)
        in Tabs (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by SubForm)
        in div (created by SubForm)
        in SubForm (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by HostEditForm)
        in HostEditForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to AsyncCredentials inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in AsyncCredentials (created by ValidateHostCredentials)
        in ValidateHostCredentials (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by Tabs)
        in div (created by Tabs)
        in div (created by TabContent)
        in TabContent (created by Tabs)
        in Tabs (created by Tabs)
        in Tabs (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by SubForm)
        in div (created by SubForm)
        in SubForm (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by HostEditForm)
        in HostEditForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   2 passed, 2 total
Time:        3.968s

After

 PASS  app/javascript/spec/host-edit-form/host-edit-form.spec.js
  Show Edit Host Form Component
    ✓ should render form for *one* host (176ms)
    ✓ should render form for multiple hosts (25ms)

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   2 passed, 2 total
Time:        3.835s

@jeffibm jeffibm added the test label May 6, 2024
@jeffibm jeffibm requested a review from a team as a code owner May 6, 2024 09:10
@jeffibm jeffibm mentioned this pull request May 6, 2024
35 tasks
@GilbertCherrie
Copy link
Member

@jeffibm Please update the snapshots for this spec file, they are failing locally

@jeffibm jeffibm force-pushed the fix-host-edit-form-test branch from c03c1f8 to 0eb4765 Compare May 16, 2024 06:37
@miq-bot
Copy link
Member

miq-bot commented May 16, 2024

Checked commit jeffbonson@0eb4765 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@GilbertCherrie GilbertCherrie merged commit 3fceccb into ManageIQ:master May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants