Remove report tab technical debt#9041
Merged
jeffibm merged 1 commit intoJan 22, 2024
Merged
Conversation
Member
|
Checked commit GilbertCherrie@37801cc with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
jeffibm
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove code from the report controller to handle various tabs that do not exist in the UI.
schedules: The schedules pages do not contain any tabs
saved_reports: The saved reports tab is handled in the file: https://github.com/ManageIQ/manageiq-ui-classic/tree/master/app/views/report/_report_list.html.haml
menuEditor: There is no action that exists called menu_edit, meaning this block of tabs code is not actually doing anything.