Skip to content

Conversation

@kbrock
Copy link
Member

@kbrock kbrock commented Jan 16, 2024

Add Rbac to Switch and vlans
This is visible in the vlan dropdown in the reconfigure vm screen

@kbrock kbrock added the rbac label Jan 16, 2024
@kbrock kbrock requested a review from a team as a code owner January 16, 2024 15:45
HostSwitch does not properly apply rbac
This is visible in the vlan dropdown in the reconfigure vm screen
@kbrock
Copy link
Member Author

kbrock commented Jan 16, 2024

update:

  • rebase

@miq-bot
Copy link
Member

miq-bot commented Jan 16, 2024

Checked commit kbrock@6b3f06f with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would also like @agrare to review.

@kbrock Can we add any specs for this? I realize it's in the controller, so it might be tough.

@agrare
Copy link
Member

agrare commented Jan 16, 2024

@kbrock will this do anything if there is no tenant_id or miq_group_id on these models?

@kbrock
Copy link
Member Author

kbrock commented Jan 17, 2024

@kbrock will this do anything if there is no tenant_id or miq_group_id on these models?
-- @agrare

Before, sending a HostSwitch to rbac will do nothing since that is not a model with rbac capability.

After, sending Switch or Lan to rbac will run tag filtering since that is what rbac and the model are configured to run.

When we add the capability for tenancy filtering on Switch, then this rbac call will run that kind of filtering as well.

@Fryguy
Copy link
Member

Fryguy commented Jan 23, 2024

Backported to morphy in commit e29f0f1.

commit e29f0f190f2363fc69e4d3e4f4caf1c3c4a2e53c
Author: Jeffrey Bonson <[email protected]>
Date:   Mon Jan 22 18:21:03 2024 +0530

    Merge pull request #9036 from kbrock/network_switches
    
    Filter vlans by switch and then lan
    
    (cherry picked from commit 94b0d4151d911686d95b93edfb81cce32fc82854)

Fryguy pushed a commit that referenced this pull request Jan 23, 2024
Filter vlans by switch and then lan

(cherry picked from commit 94b0d41)
@Fryguy
Copy link
Member

Fryguy commented Jan 31, 2024

Backported to quinteros in commit 84555ae.

commit 84555ae7514aae3d7520f3b42345c369a44f376c
Author: Jeffrey Bonson <[email protected]>
Date:   Mon Jan 22 18:21:03 2024 +0530

    Merge pull request #9036 from kbrock/network_switches
    
    Filter vlans by switch and then lan
    
    (cherry picked from commit 94b0d4151d911686d95b93edfb81cce32fc82854)

Fryguy pushed a commit that referenced this pull request Jan 31, 2024
Filter vlans by switch and then lan

(cherry picked from commit 94b0d41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants