Skip to content

Conversation

@jeffibm
Copy link
Member

@jeffibm jeffibm commented Feb 24, 2023

This Pr is to test the implementation of Drag and Drop for Service Dialogs revamp (POC)

  • Create a Component for the vertical components list - DynamicComponentChooser
  • Create a Component for the tabs, sections, fields - (to be changed from MiqDragAndDrop)
  • Create a default tab with a blank section
  • The last tab's click event will create a new tab with a blank section.
  • Create a Component for each sections under a tab - DynamicSection
  • Create a Component for each field which comes under a section - DynamicField
  • Create Components for each field
  • Text Box
  • Text Area
  • Check Box
  • Dropdown
  • Radio Button
  • Datepicker
  • Timepicker
  • Tag Control
  • Add/Delete new Section
  • Add new Tab
  • Provide a menu for tabs
  • Delete tab
  • Drag an item from DynamicComponentChooser and drop it into a section
  • Drag and drop an item inside a section to change the order
  • Drag and drop a section to change the order.
  • Selected item will be converted into an actual field
  • Minimize / Maximise section since the page will become big (new feature)
  • Edit options for Tab in a model box
  • Edit options for Sections in a model box
  • Edit options for Field in a model box
  • Text Box
  • Text Area
  • Check Box
  • Dropdown
  • Radio Button
  • Datepicker
  • Timepicker
  • Tag Control
  • Store Tab options
  • Store Section options
  • Store field options
  • Store/manage all information.
  • Include MiqFormRenderer and Formspy
  • Submit action
  • View saved item
  • Edit Page

First demo:
https://user-images.githubusercontent.com/87487049/221094077-b2dbeaa0-a3c6-4578-b90c-c6c07b006115.mov

current update - #8666 (comment)

Just putting it here - https://www.data-driven-forms.org/editor/live-editor

@jeffibm jeffibm requested a review from a team as a code owner February 24, 2023 04:48
@miq-bot miq-bot added the wip label Feb 24, 2023
@jeffibm
Copy link
Member Author

jeffibm commented Feb 24, 2023

Screen.Recording.2023-02-24.at.6.55.38.PM.mov
  • Trying to see if I can get the DDF integrated into this.
  • Drag and drop breaks now break due to multiple renders on the drop event which can be fixed.

@jeffibm
Copy link
Member Author

jeffibm commented Feb 27, 2023

earlier we had issues when we drop a field, it gets added to all sections. that has been corrected now.
will be trying to see if we can integrate actual fields to the form.

Screen.Recording.2023-02-27.at.8.11.07.PM.mov

@jeffibm
Copy link
Member Author

jeffibm commented Feb 28, 2023

integrated textbook and text area during drag and drop
fixed the react-hook-related warning

Screen.Recording.2023-02-28.at.12.51.18.PM.mov

@Fryguy
Copy link
Member

Fryguy commented Feb 28, 2023

This is beautiful 😍 - amazing work!

@Fryguy Fryguy changed the title [WIP] Basic drag and drop implementation [WIP] Service dialogs - Basic drag and drop implementation Feb 28, 2023
@Fryguy Fryguy added this to the Petrosian milestone Feb 28, 2023
@Fryguy Fryguy changed the title [WIP] Service dialogs - Basic drag and drop implementation [WIP] Service dialogs - React drag and drop implementation Feb 28, 2023
@jeffibm
Copy link
Member Author

jeffibm commented Mar 5, 2023

code cleaning and refactoring required at this stage.

Screen.Recording.2023-03-05.at.9.25.55.PM.mov

@jeffibm
Copy link
Member Author

jeffibm commented Apr 9, 2023

when we mouse hover on a field in a section, an edit and remove buttons will be displayed.
when we click on the edit button, a dialog box appears and displayes tabs and its options.
image

@jeffibm jeffibm changed the title [WIP] Service dialogs - React drag and drop implementation [WIP] Service dialogs form conversion Apr 9, 2023
@jeffibm jeffibm force-pushed the jbn-service-catalogs-poc-1 branch 2 times, most recently from 8bb71cf to 5ebbfe2 Compare April 22, 2023 09:21
@jeffibm
Copy link
Member Author

jeffibm commented Apr 22, 2023

Added schema for text field options
image

@jeffibm jeffibm force-pushed the jbn-service-catalogs-poc-1 branch from 90dc4b9 to 2df0f69 Compare April 24, 2023 04:54
@miq-bot miq-bot added the stale label Jul 31, 2023
@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this Nov 6, 2023
@miq-bot
Copy link
Member

miq-bot commented Nov 6, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@jeffibm jeffibm reopened this Nov 6, 2023
@miq-bot miq-bot closed this Nov 20, 2023
@miq-bot
Copy link
Member

miq-bot commented Nov 20, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@jeffibm jeffibm reopened this Nov 20, 2023
@miq-bot
Copy link
Member

miq-bot commented Feb 26, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented May 27, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@GilbertCherrie GilbertCherrie force-pushed the jbn-service-catalogs-poc-1 branch from 2df0f69 to 275f576 Compare June 13, 2024 20:05
@jeffibm jeffibm force-pushed the jbn-service-catalogs-poc-1 branch from 97b1153 to 63da6cb Compare July 18, 2024 04:20
@miq-bot
Copy link
Member

miq-bot commented Jul 18, 2024

Checked commit jeffbonson@63da6cb with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@jeffbonson
Copy link
Contributor

Handover

  • At this stage, it's more like 20% complete. See the PR description for more info.
  • Even though it is possible to implement features of one field item, say a text-input field, it would result in a lot of code duplication. Instead, we need a map for all field options.
  • I have created a folder named fieldOptionsMap which maps down the options modal box for each field. It's just for reference purposes only.
  • You will need a logic to build the options-modal box for each field (this is partially done, but since this was a POC, this needs more work)
  • You need to rely on the react context providers feature to handle data across the form. thereby you can reduce the callback and a lot of code.
  • You will need 2 validators/classes. one to handle the options-modal-box form and the other for the actual form data
  • Try to get the designs similar to PR#8991
  • The dialog summary section is already handled in the PR#8991
  • We need to think of the dialog edit page for an existing record.
  • I was thinking of removing the options-modal-box itself, since, it looks big with all those fields in the new design. In the old design, all of it would fit in that small modal box. Maybe, if we can introduce a right-panel for editing the field/tab/section, that would look much cleaner. We can try the designs using Figma and get more suggestions before implementing them.

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

2 similar comments
@miq-bot
Copy link
Member

miq-bot commented Feb 3, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented May 5, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: To do

Development

Successfully merging this pull request may close these issues.

4 participants