[WIP] Convert order service form to react #8484
Conversation
GilbertCherrie
changed the title
Only call supports? on non-nil objects.
- `MiqTask#task_results` returns `nil` even when validation succeeds, since physical storage validation tasks don't get a `binary_blob` for some reason (while validate provider tasks do, for instance). - `validateStorage` in `app/javascript/components/physical-storage-form/validate-storage-credentials.jsx` checked `task_result` and not `status` or `message`, and a comment explained this was because "the wait_for_task request can succeed with valid or invalid credentials with the message that the task is completed successfully. Based on the task_results we resolve() or reject() with an unknown error." - this comment was copied from another object validation code (probably from validate provider), but it is not correct: invalid credentials or valid credentials for an already connected ip throw an error, and the request fails. - the above enables simply checking if status is 'Ok'. - added a function to edit error messages received from AutoSDE, to display only the "bottom line".
[skip ci]
…unfixed event by storage system.
It was added in a just merged PR: ManageIQ#8429 There is no need for interpolation here. Fixes a brakeman warning: Confidence: Medium Category: SQL Injection Check: SQL Message: Possible SQL injection Code: EmsEvent.where("ems_id=#{@ems_id}") File: ../../.gem/ruby/2.7.6/bundler/gems/manageiq-ui-classic-dd7330eae02e/app/services/ems_storage_dashboard_service.rb Line: 102
Ui classic is different in that we want to test all suites against the current ruby, 3.0, but really only the spec suite cares so we also just run this one suite against the other supported ruby, 2.7.
|
Wow - this is really impressive given how complicated these forms are 👍 |
jeffibm
force-pushed
the
convert_order_service_form
branch
from
8525f7b to
31da467
Compare
|
working on the refresh button action..
|
|
Note : need to check if we can use the same schema in render the show page here |
ToDo
|
jeffibm
force-pushed
the
convert_order_service_form
branch
from
b43f548 to
3b223f5
Compare
|
wip -
|
Screen.Recording.2023-09-01.at.11.56.47.AM.mov |
|
Hey @GilbertCherrie , Screen.Recording.2023-09-04.at.3.26.52.PM.mov |
jeffibm
force-pushed
the
convert_order_service_form
branch
from
ee272ae to
438f2e4
Compare
|
Checked commit GilbertCherrie@438f2e4 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint app/views/miq_request/_request_dialog_details.html.haml
app/views/shared/dialogs/_dialog_user.html.haml
|
|
This pull request is not mergeable. Please rebase and repush. |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
5 similar comments
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
GilbertCherrie
force-pushed
the
convert_order_service_form
branch
from
438f2e4 to
59104f8
Compare
16 participants
continuing work in - #8911
This PR is blocked due to the refresh button and refresh fields options which can not be easily replicated using DDF at this moment.
Converted the Order Service Form from Angular to React. This is a dialog form which can be edited by the user so the fields will be different for each form. An example of this form being rendered is:
Before:
After:
