Omit test/ dir from built .gem (v4.y branch) #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cben
changed the title
test_files is deprecated. It was causing all tests to be shipped in the .gem file, which is useless bloat: rubygems/guides#90 Compressed kubeclient-4.9.1.gem was 78KB, now down to 33KB. Unpacked size 757KB -> 184KB.
cben
force-pushed
the
dont_ship_test_files
branch
from
a796093 to
f8b3ce7
Compare
|
to be forward-ported to master too. |
cben
added a commit
to cben/kubeclient
that referenced
this pull request
May 30, 2021
- Forward-port ManageIQ#502. - Mark some v4.9.2 backports as clean for future merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #501.
test_filesis deprecated. It was causing all tests to be shipped in the .gem file, which is useless bloat (was questionable tradeoff before when rubygems supported running tests for a downloaded gem, anyway no longer supported): rubygems/guides#90