Drop attributes_builder #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in f53272a we removed 5.1 support, so no longer needed to override this method Should have deleted this method I had expected some exclusion for virtual attributes, but stock has been working since 5.2, so letting it slide
Member
|
Checked commit kbrock@3c628ac with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
jrafanie
approved these changes
Jul 30, 2024
Member
jrafanie
left a comment
jrafanie
left a comment
There was a problem hiding this comment.
LGTM, this is small enough and make sense... let's get this in now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #150
in f53272a we removed 5.1 support, so no longer needed to override this method Should have deleted this method
I had expected some exclusion for virtual attributes, but stock has been working since 5.2, so letting it slide