replace_virtual_field condenses returning includes

[kbrock]

relace_virtual_field sometimes returns unnecessary tiers of embedded hashes or arrays. E.g. [[:field]] instead of :field.

6.1 has one fixes, but is by no means exhaustive:

association = association.first if association.kind_of?(Array) && association.size == 1

This fixes replace_virtual_field to not output that value. Since this is at the return of each level, it essentially applied recursively and flattens it significantly.

Added freeze in tests to verify that the input parameter is unmodified.

[kbrock]

update:

• rubocop: added parens
• renamed demote_includes to simplify_includes

[kbrock]

this is now part of #133 - we can merge here or there

[kbrock]

update:

• pulled out of Add rails 7.0 support and drop rails 6.1 #150

update:

• fixed bug introduced by rebase

[jrafanie]

@kbrock I'm not sure what this fixes. It looks like it fixes a bug but can't envision how this occurs.

In the rails 7.0 migration, I had [[:field]] that I needed to convert into [:field].

Can you describe the problem you had here?

[kbrock]

Hey @jrafanie

ok, I added a pre-commit to this PR.
First commit shows the output with a double array example.
The second commit shows that this example is fixed.

This over optimizes the list for rails 7, and that is why I added the Array[klass_associations] in the preloader - that rubocop did not like.

[miq-bot]

Checked commits kbrock/activerecord-virtual_attributes@153a10f~...a1d7249 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 0 offenses detected
Everything looks fine. 👍

[jrafanie]

Ok, let's get this in and tested with our rails 7 work.