Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to new JSServe version #2633

Merged
merged 2 commits into from
Jan 27, 2023
Merged

adapt to new JSServe version #2633

merged 2 commits into from
Jan 27, 2023

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Jan 26, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 29.96s (29.88, 30.15) 0.09+- 16.59s (16.46, 16.72) 0.10+- 15.56s (15.46, 15.68) 0.07+- 9.43ms (9.28, 9.54) 0.11+- 112.52ms (111.83, 113.63) 0.59+-
master 30.03s (29.84, 30.21) 0.11+- 16.56s (16.45, 16.75) 0.11+- 15.44s (15.29, 15.85) 0.20+- 9.40ms (9.22, 9.63) 0.15+- 112.54ms (111.36, 114.09) 0.87+-
evaluation -0.21%, -0.06s invariant (-0.61d, 0.27p, 0.10std) +0.21%, 0.03s invariant (0.33d, 0.55p, 0.10std) +0.72%, 0.11s invariant (0.75d, 0.20p, 0.14std) +0.32%, 0.03ms invariant (0.23d, 0.67p, 0.13std) -0.01%, -0.01ms invariant (-0.02d, 0.97p, 0.73std)
CairoMakie 33.45s (33.13, 33.66) 0.21+- 20.93s (20.63, 21.14) 0.19+- 3.26s (3.20, 3.33) 0.05+- 13.44ms (13.19, 13.68) 0.18+- 5.63ms (5.47, 5.77) 0.11+-
master 33.63s (33.43, 33.82) 0.13+- 20.88s (20.68, 21.38) 0.25+- 3.22s (3.19, 3.27) 0.03+- 13.41ms (13.28, 13.59) 0.11+- 5.72ms (5.58, 5.95) 0.13+-
evaluation -0.54%, -0.18s invariant (-1.02d, 0.09p, 0.17std) +0.26%, 0.05s invariant (0.25d, 0.66p, 0.22std) +1.04%, 0.03s invariant (0.87d, 0.13p, 0.04std) +0.29%, 0.04ms invariant (0.26d, 0.64p, 0.14std) -1.58%, -0.09ms invariant (-0.74d, 0.19p, 0.12std)
WGLMakie
master
evaluation

@SimonDanisch
Copy link
Member Author

Ok, WGLMakie benchmark is expected to fail, since master is still broken and it compares against that...

@SimonDanisch SimonDanisch merged commit 07c5f61 into master Jan 27, 2023
@SimonDanisch SimonDanisch deleted the sd/jsserve2.1 branch January 27, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants