Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed-axis camera rotation Y and Z axes swapped #2721

Closed
pbouffard opened this issue Mar 1, 2023 · 0 comments · Fixed by #3113
Closed

Fixed-axis camera rotation Y and Z axes swapped #2721

pbouffard opened this issue Mar 1, 2023 · 0 comments · Fixed by #3113

Comments

@pbouffard
Copy link
Contributor

I noticed that holding down the y or z keys while dragging to rotate the 3D scene appears to rotate about the wrong world axis (about y when z is pressed and vice versa).

I think the culprit is this line: https://github.com/MakieOrg/Makie.jl/blob/master/src/camera/camera3d.jl#L487:

rotation *= qrotation(
                Vec3f(fix_x, fix_z, fix_y) .* Vec3f(sign(right[1]), viewdir[2], sign(up[3])),
                dot(Vec3f(fix_x, fix_y, fix_z), angles)
            )

Just swapping the 2nd and 3rd arguments to the first Vec3f appears to fix the issue.
@ffreyer ffreyer mentioned this issue Mar 13, 2023
Closed
4 tasks
@SimonDanisch SimonDanisch moved this to In Progress in Makie usability Apr 25, 2023
@ffreyer ffreyer mentioned this issue Aug 21, 2023
Merged
16 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Makie usability Nov 17, 2023
SimonDanisch added a commit that referenced this issue Nov 17, 2023
@SimonDanisch
Rebased version of beta 0.20 (#3113)
090a3fb 
Continues #2831 !
Still needs to check, if I rebased correctly and didn't incorrectly
apply some of the changes!

## Merged PRs
- #2598
- #2746
- #2346
- #2544
- #3082
- #2868
- #3062
- #3106
- #3281
- #3246

## TODOS

- [x] fix flaky test `@test GLMakie.window_size(screen.glscreen) ==
scaled(screen, (W, H))`
- [x] Merge axis type inferences from #2220 
- [x] Test on different resolution screens, IJulia, Pluto, VSCode,
Windowed
- [x] rebase to only have merge commits from the PRs 
- [x] investigate unexpected speed ups
- [x] reset camera settings from tests
- [ ] check doc image generation
- [x] rethink default near/far in Camera3D (compatability with OIT)
- [x] merge #3246
- [x] fix WGLMakie issues/tests:
- [x] fix line depth issues (see tests: ~~hexbin colorrange~~ (not new),
LaTeXStrings in Axis3, Axis3 axis reversal)
  - [x] fix lighting of surface with nan points (fixed in #3246)
- ~~volume/3D contour artifacts (see 3D Contour with 2D contour
slices)~~ not new
  - ~~artifacting in "colorscale (lines)"~~ not new
- [x] GLMakie:
  - [x] slight outline in "scatter image markers" test
  - ~~clipping/z-fighting in "volume translated"~~ not new
- [x] CairoMakie:
  -  ~~Artfiacting in `colorscale (lines)"~~ not new
  - ~~markersize in "scatter rotations" changed?~~ not new
  - ~~color change in "colorscale (poly)"~~ not new
  - ~~transparency/render order of "OldAxis + Surface"~~ not new
  - ~~render order in "Merged color mesh"~~ not new
  - ~~render order of "Surface + wireframe + contour"~~ not new
- [x] Check "SpecApi in convert_arguments" (colors swapped?)


## Fixes the following errors

- fixes #2721 via #2746
- fixes #1600 via #2746
- fixes #1236 via #2746
- fixes MakieOrg/GeoMakie.jl#133 via #2598
- closes #2522
- closes #3239 via #3246
- fixes #3238 via #3246
- fixes #2985 via #3246
- fixes #3307 via #3281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Makie usability
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rebased version of beta 0.20 MakieOrg/Makie.jl
Camera3D Improvements MakieOrg/Makie.jl
1 participant
@pbouffard