Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_local_notifications] [WIP] Windows implementation of notifications #1472

Closed
wants to merge 1 commit into from

Conversation

kennethnym
Copy link

@kennethnym kennethnym commented Feb 9, 2022

This draft PR contains Windows implementation of this plugin. Still a WIP.

Note: dependency_overrides in pubspec.yaml is simply for testing purposes. It will be removed before this PR is merged.

cc @azchohfi
Related issue: #746

@MaikuB
Copy link
Owner

MaikuB commented Feb 9, 2022

Thanks, I know it's WIP but thought I'd share some tips

  • if you are planning to submit a PR from your fork to any repository, I'd you create a feature branch in your fork for it. This way you can update main/master more easily when the parent repo is updated
  • this plugin uses melos so you shouldn't need to override dependencies. Bootstrap melos and you should be set. The docs for melos can be found at https://melos.invertase.dev

@kennethnym
Copy link
Author

Thank you. I will make a separate branch in my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants